Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rblob: Upgrade to AWS SDK v2 #23

Merged
merged 1 commit into from
Nov 4, 2024
Merged

rblob: Upgrade to AWS SDK v2 #23

merged 1 commit into from
Nov 4, 2024

Conversation

NeilLuno
Copy link
Contributor

@NeilLuno NeilLuno commented Nov 4, 2024 •
edited
Loading

gocloud.dev/blob/s3blob is doing a type assertion on the on the ListObjectsV2Input we're providing it. We're providing a "v1" ListObjectsV2Input, but it's expecting a v2 ListObjectsV2Input.

This change upgrades rblob to the v2 AWS SDK.

Fixes #22.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@echarrod
Copy link
Contributor

echarrod commented Nov 4, 2024 •
edited
Loading

Fixes #22

@NeilLuno btw, think if you prefix issue link with fixes (or others), (might need to be in PR description) it auto-closes the issue when the PR is merged 👍

@NeilLuno NeilLuno merged commit 361bf8e into main Nov 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@echarrod echarrod echarrod approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rblob prefix not being applied correctly
2 participants
@NeilLuno @echarrod